Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 15792028: Update ChromeVox manifest. (Closed)

Created:
7 years, 6 months ago by David Tseng
Modified:
7 years, 6 months ago
Reviewers:
dmazzoni, zel
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update ChromeVox manifest. BUG=none TEST=Sanity check ChromeVox on Chrome Aura. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/access_chromevox/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
David Tseng
7 years, 6 months ago (2013-06-07 20:53:55 UTC) #1
dmazzoni
lgtm
7 years, 6 months ago (2013-06-07 20:55:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/15792028/1
7 years, 6 months ago (2013-06-07 21:09:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=7717
7 years, 6 months ago (2013-06-07 21:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/15792028/1
7 years, 6 months ago (2013-06-07 21:53:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=7729
7 years, 6 months ago (2013-06-07 22:07:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/15792028/1
7 years, 6 months ago (2013-06-09 02:57:54 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=7837
7 years, 6 months ago (2013-06-09 03:07:52 UTC) #8
David Tseng
+ zelidrag for OWNERS approval.
7 years, 6 months ago (2013-06-10 16:22:44 UTC) #9
zel
lgtm
7 years, 6 months ago (2013-06-10 17:00:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/15792028/1
7 years, 6 months ago (2013-06-10 17:06:08 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 22:52:54 UTC) #12
Message was sent while issue was closed.
Change committed as 205333

Powered by Google App Engine
This is Rietveld 408576698