chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java - Issue 1578433002: Implementation of newly designed sign in related histograms for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

Issue 1578433002: Implementation of newly designed sign in related histograms for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: import RecordHistogram in SigninManager Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

index 3cccd6cbfd8b0ad235ac16cebd699650a3827e0d..d581d62e6d4a56d8683e12e45ac1feeab719aa86 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

@@ -61,6 +61,7 @@ public class SigninPromoScreen

SigninPromoScreen promoScreen = new SigninPromoScreen(activity);

promoScreen.show();

+ SigninManager.logSigninStartAccessPoint(SigninAccessPoint.SIGNIN_PROMO);

preferenceManager.setSigninPromoShown();

return true;

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java ('k') | chrome/chrome.gyp » ('j') | no next file with comments »