chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java - Issue 1578433002: Implementation of newly designed sign in related histograms for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

Issue 1578433002: Implementation of newly designed sign in related histograms for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: import RecordHistogram in SigninManager Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

index 76a086a99bb8cfea8df1a60b23c8dcd0fe685a67..6a9496ce992266542b829e8c4f2dbda12ac29d99 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

@@ -24,6 +24,7 @@ import org.chromium.chrome.browser.preferences.datareduction.DataReductionPrefer

import org.chromium.chrome.browser.signin.AccountAdder;

import org.chromium.chrome.browser.signin.AddGoogleAccountDialogFragment;

import org.chromium.chrome.browser.signin.AddGoogleAccountDialogFragment.AddGoogleAccountListener;

+import org.chromium.chrome.browser.signin.SigninAccessPoint;

import org.chromium.chrome.browser.signin.SigninManager;

import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;

import org.chromium.chrome.browser.sync.ui.ChooseAccountFragment;

@@ -202,6 +203,7 @@ public class MainPreferences extends PreferenceFragment implements SignInStateOb

new ChooseAccountFragment(accountNames);

chooserFragment.show(getFragmentManager(), ACCOUNT_PICKER_DIALOG_TAG);

callback.onResult(chooserFragment);

+ SigninManager.logSigninStartAccessPoint(SigninAccessPoint.SETTINGS);

}

} else {

AddGoogleAccountDialogFragment dialog = new AddGoogleAccountDialogFragment();