chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java - Issue 1578433002: Implementation of newly designed sign in related histograms for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 1578433002: Implementation of newly designed sign in related histograms for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: import RecordHistogram in SigninManager Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

index 03187835cdfd7f15e58964649c77ae8358f8648f..fdd9e722f08572173778b5e02fb348122270ecf9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

@@ -26,6 +26,8 @@ import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoScreen;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;

import org.chromium.chrome.browser.profiles.Profile;

+import org.chromium.chrome.browser.signin.SigninAccessPoint;

+import org.chromium.chrome.browser.signin.SigninManager;

import java.lang.ref.WeakReference;

import java.lang.reflect.Constructor;

@@ -307,6 +309,7 @@ public class FirstRunActivity extends AppCompatActivity implements FirstRunPageD

public void onSigninDialogShown() {

RecordUserAction.record("MobileFre.SignInShown");

RecordUserAction.record("Signin_Impression_FromStartPage");

+ SigninManager.logSigninStartAccessPoint(SigninAccessPoint.START_PAGE);

}

@Override