Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15782010: Update remoting/ and jingle/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Update remoting/ and jingle/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -174 lines) Patch
M jingle/glue/channel_socket_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/fake_socket_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/fake_ssl_client_socket.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/base/auto_thread.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M remoting/base/compound_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/compound_buffer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/rsa_key_pair.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/rsa_key_pair_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/socket_reader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/client/chromoting_client.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M remoting/client/client_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/audio_capturer_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M remoting/host/client_session.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/desktop_process.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/host_port_allocator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/ipc_util_posix.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/register_support_host_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/start_host.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/signaling_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/token_validator_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/url_request_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/jingle_glue/chromium_socket_factory.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M remoting/jingle_glue/javascript_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/buffered_socket_writer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer_unittest.cc View 3 chunks +26 lines, -12 lines 0 comments Download
M remoting/protocol/connection_tester.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_reader.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-01 01:47:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15782010/1
7 years, 6 months ago (2013-06-01 01:47:44 UTC) #2
commit-bot: I haz the power
Change committed as 203573
7 years, 6 months ago (2013-06-01 04:33:19 UTC) #3
darin (slow to review)
7 years, 6 months ago (2013-06-01 21:42:54 UTC) #4 
LGTM
On May 31, 2013 9:33 PM, <commit-bot@chromium.org> wrote:

> Change committed as 203573
>
>
https://chromiumcodereview.**appspot.com/15782010/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698