Added bowser test for Captive Portal Window.

Added bowser test for Captive Portal Window.

BUG=244175
TEST=interactive_ui_tests:CaptivePortalWindow*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202544

[Nikita (slow), 2013-05-27 16:55:34]

lgtm with one UX improvement suggestion.

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/captive_portal_window_browsertest.cc (right):

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/captive_portal_window_browsertest.cc:135:
CheckState(true, 1);
It makes sense to improve UX which this test shows.

1. ShowIfRedirected()
2. Show (user opens window manually i.e. overriding automatic behaviour for
opening)
3. Close (i.e. user closes window manually i.e. doesn't want it to popup)
4. Redirect happens - I thinkg that CP window should not open automatically.
Let's consider (2) and/or (3) as user "manual override over automatic open
behavior".

If user opens window manually and then proper redirect happens (i.e. to original
URL) then it is OK to close window automatically (this case is already tested
here).

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/captive_portal_window_proxy.h (right):

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/captive_portal_window_proxy.h:67: // starts load.
nit: starts loading CP redirect URL.

[ygorshenin1, 2013-05-28 10:04:14]

PTAL, as logic was slightly changed.

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/captive_portal_window_browsertest.cc (right):

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/captive_portal_window_browsertest.cc:135:
CheckState(true, 1);
On 2013/05/27 16:55:35, Nikita Kostylev wrote:
> It makes sense to improve UX which this test shows.
> 
> 1. ShowIfRedirected()
> 2. Show (user opens window manually i.e. overriding automatic behaviour for
> opening)
> 3. Close (i.e. user closes window manually i.e. doesn't want it to popup)
> 4. Redirect happens - I thinkg that CP window should not open automatically.
> Let's consider (2) and/or (3) as user "manual override over automatic open
> behavior".
> 
> If user opens window manually and then proper redirect happens (i.e. to
original
> URL) then it is OK to close window automatically (this case is already tested
> here).

Done.

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/captive_portal_window_proxy.h (right):

https://codereview.chromium.org/15780006/diff/1004/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/captive_portal_window_proxy.h:67: // starts load.
On 2013/05/27 16:55:35, Nikita Kostylev wrote:
> nit: starts loading CP redirect URL.

Done.

[Nikita (slow), 2013-05-28 10:18:40]

lgtm

[commit-bot: I haz the power, 2013-05-28 10:19:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/15780006/8001

[commit-bot: I haz the power, 2013-05-28 13:42:53]

Change committed as 202544