Issue 15778012: Fix bogus assertions for tracing and verify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15778012: Fix bogus assertions for tracing and verify. (Closed)

Created:
7 years, 6 months ago by Yang

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bogus assertions for tracing and verify. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14985

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
		src/hydrogen.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://chromiumcodereview.appspot.com/15778012/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/15778012/diff/1/src/hydrogen.cc#newcode530 src/hydrogen.cc:530: AllowHandleDereference ahd; Can we rename ...

7 years, 6 months ago (2013-06-06 15:22:40 UTC) #2

Yang

7 years, 6 months ago (2013-06-06 15:30:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14985 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15778012: Fix bogus assertions for tracing and verify. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages