Issue 15774015: Fixed problem with clicking on app launcher item

Issue 15774015: Fixed problem with clicking on app launcher item (Closed)

Created:
7 years, 6 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 6 months ago

Reviewers:
xiyuan, James Cook, DaveMoore

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed problem with clicking on app launcher item Had to also adjust the new drag and drop host proxy image to be at the same place where the "legacy" icon was to make the animation smoother. BUG=245511 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203588

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed #

Total comments: 2

Patch Set 3 : Addressed windows build issue #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -13 lines)			Patch
M	ash/launcher/launcher_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	ui/app_list/views/app_list_drag_and_drop_host.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/app_list/views/app_list_item_view.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	ui/app_list/views/apps_grid_view.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/app_list/views/apps_grid_view.cc	View	1 2	5 chunks	+20 lines, -11 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM after comments addressed. https://codereview.chromium.org/15774015/diff/1/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/15774015/diff/1/ui/app_list/views/apps_grid_view.cc#newcode924 ui/app_list/views/apps_grid_view.cc:924: ui::LayerAnimator::PreemptionStrategy strategy = Use ui::ScopedLayerAnimationSettings ...

7 years, 6 months ago (2013-05-31 22:33:10 UTC) #2

Mr4D (OOO till 08-26)

Dave, could you please do an owners review? https://codereview.chromium.org/15774015/diff/1/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/15774015/diff/1/ui/app_list/views/apps_grid_view.cc#newcode924 ui/app_list/views/apps_grid_view.cc:924: ui::LayerAnimator::PreemptionStrategy ...

7 years, 6 months ago (2013-05-31 22:51:24 UTC) #3

Mr4D (OOO till 08-26)

Adding xiyuan as owners review since he is available. Thanks!

7 years, 6 months ago (2013-05-31 22:57:33 UTC) #4

xiyuan

LGTM after we fix the win compile. https://codereview.chromium.org/15774015/diff/5001/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/15774015/diff/5001/ui/app_list/views/apps_grid_view.cc#newcode926 ui/app_list/views/apps_grid_view.cc:926: view->layer()->SetOpacity(hide ? ...

7 years, 6 months ago (2013-05-31 23:06:17 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/15774015/24001

7 years, 6 months ago (2013-05-31 23:10:09 UTC) #6

Mr4D (OOO till 08-26)

Addressed and sent to CQ https://codereview.chromium.org/15774015/diff/5001/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/15774015/diff/5001/ui/app_list/views/apps_grid_view.cc#newcode926 ui/app_list/views/apps_grid_view.cc:926: view->layer()->SetOpacity(hide ? 0 : ...

7 years, 6 months ago (2013-05-31 23:32:20 UTC) #7

Message was sent while issue was closed.

Change committed as 203588

Expand Messages | Collapse Messages