views::Label displaying the tooltip should not elide.

views::Label displaying the tooltip should not elide.
The default eliding behavior on views::Label was changed to ELIDE_AT_END in
https://codereview.chromium.org/14654018 which make tooltips display incorrectly
in chromeos.

BUG=none
TEST=manual: trigger a long tooltip (one that cannot fit in one line). For
example, hover over the tab of any page with a long title (try the codereview
link above). Without this change, the tooltip label appears as a single line
elided at the end and has a weird size.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202039

[Peter Kasting, 2013-05-22 20:29:32]

How could this have worked before?  The old NO_ELIDE behavior actually elided. 
There was no case where the label truly did not elide at all.

You say "one that cannot fit in one line".  Did the old code assume that long
tooltips would get auto-wrapped to multiple lines?  If so you need to set the
label to be multi-line, not turn off eliding.

[Peter Kasting, 2013-05-22 20:30:01]

(Suggestion: screenshot the before and after behavior)

[varunjain, 2013-05-22 20:43:38]

screenshots attached for before
ttps://codereview.chromium.**org/14654018<https://codereview.chromium.org/14654018>
and
after. Notice no elide and two lines tooltip in before.png vs. single line
elided tooltip in after.png

I tried setting multiline to true. But the sizing (particularly height) is
all messed up. Seems like Label::GetPreferredSize() which I use to
determine the height of the widget returns incorrect height when multi line
is set. I am investigating that further.


On Wed, May 22, 2013 at 4:30 PM, <pkasting@chromium.org> wrote:

> (Suggestion: screenshot the before and after behavior)
>
>
https://codereview.chromium.**org/15772002/<https://codereview.chromium.org/1...
>

[Peter Kasting, 2013-05-22 21:24:48]

On 2013/05/22 20:43:38, varunjain wrote:
> I tried setting multiline to true. But the sizing (particularly height) is
> all messed up. Seems like Label::GetPreferredSize() which I use to
> determine the height of the widget returns incorrect height when multi line
> is set. I am investigating that further.

You need to set a max width when you have a multiline label.

It definitely looks here like rather than NO_ELIDE, the right answer is
something related to SetMultiLine().

[varunjain, 2013-05-23 18:46:51]

On 2013/05/22 21:24:48, Peter Kasting wrote:
> On 2013/05/22 20:43:38, varunjain wrote:
> > I tried setting multiline to true. But the sizing (particularly height) is
> > all messed up. Seems like Label::GetPreferredSize() which I use to
> > determine the height of the widget returns incorrect height when multi line
> > is set. I am investigating that further.
> 
> You need to set a max width when you have a multiline label.
> 
> It definitely looks here like rather than NO_ELIDE, the right answer is
> something related to SetMultiLine().

Changed to using SetMultiLine. PTAL.

[sadrul, 2013-05-23 21:54:53]

lgtm

[commit-bot: I haz the power, 2013-05-23 22:11:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/15772002/9001

[Peter Kasting, 2013-05-23 22:12:49]

LGTM

[commit-bot: I haz the power, 2013-05-24 09:51:54]

Change committed as 202039