Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 15771010: Retire Valgrind suppressions (Closed)

Created:
7 years, 6 months ago by Eric Willigers
Modified:
7 years, 6 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Retire Valgrind suppressions A number of memory leaks and reads of uninitialized memory are no longer occurring. BUG=31800, 103467, 107503, 107698, 169311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204937

Patch Set 1 #

Patch Set 2 : restore suppression 243132 #

Patch Set 3 : Stop suppressing 107698a 107698b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -81 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 2 5 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Eric Willigers
7 years, 6 months ago (2013-06-06 08:58:30 UTC) #1
Timur Iskhodzhanov
2013/6/6 <ericwilligers@chromium.org>: > Reviewers: Timur Iskhodzhanov, > > Description: > Retire Valgrind suppressions > > ...
7 years, 6 months ago (2013-06-06 10:23:07 UTC) #2
Eric Willigers
Listed all the bugs that are being fixed.
7 years, 6 months ago (2013-06-07 00:52:03 UTC) #3
Eric Willigers
Rebased. Removed suppression for 243132 as it occurred again.
7 years, 6 months ago (2013-06-07 05:21:21 UTC) #4
Timur Iskhodzhanov
I'm a bit busy today, so deferring to Alexander.
7 years, 6 months ago (2013-06-07 09:30:37 UTC) #5
Alexander Potapenko
LGTM with two nits: This CL doesn't touch any suppressions for bug 100981, please remove ...
7 years, 6 months ago (2013-06-07 09:49:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15771010/10001
7 years, 6 months ago (2013-06-07 19:09:09 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 21:38:54 UTC) #8
Message was sent while issue was closed.
Change committed as 204937

Powered by Google App Engine
This is Rietveld 408576698