Issue 15769013: Make WebFrameTest to not need soon-to-be-removed Persistent handle operations.

Issue 15769013: Make WebFrameTest to not need soon-to-be-removed Persistent handle operations. (Closed)

Created:
7 years, 6 months ago by marja

Modified:
7 years, 6 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
blink-reviews, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make WebFrameTest to not need soon-to-be-removed Persistent handle operations. BUG=236290 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151847

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	Source/WebKit/chromium/tests/WebFrameTest.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

marja

dcarney, ptal After this one, all_webkit will build without V8_USE_UNSAFE_HANDLES with the "Persistent::operator-> enabled" hack.

7 years, 6 months ago (2013-06-05 14:22:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15769013/1

7 years, 6 months ago (2013-06-05 14:29:18 UTC) #3

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1143

7 years, 6 months ago (2013-06-05 14:40:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15769013/1

7 years, 6 months ago (2013-06-05 14:45:48 UTC) #7

Message was sent while issue was closed.

Change committed as 151847

Expand Messages | Collapse Messages