Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 15767005: [MediaGalleries] Add temp dir adjustment in windows unit test. (Closed)

Created:
7 years, 7 months ago by Greg Billock
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[MediaGalleries] Add temp dir adjustment in windows unit test. This accounts for test environments that may have the TMP directory on drives that aren't C:. R=vandebo@chromium.org,ajwong@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203086

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Fix syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc View 1 2 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Greg Billock
7 years, 7 months ago (2013-05-25 00:48:59 UTC) #1
vandebo (ex-Chrome)
LGTM https://codereview.chromium.org/15767005/diff/1/chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc File chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc (right): https://codereview.chromium.org/15767005/diff/1/chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc#newcode64 chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc:64: base::ScopedTempDir temp_dir; nit: looks like this chunk could ...
7 years, 6 months ago (2013-05-28 16:10:43 UTC) #2
Greg Billock
https://codereview.chromium.org/15767005/diff/1/chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc File chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc (right): https://codereview.chromium.org/15767005/diff/1/chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc#newcode64 chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc:64: base::ScopedTempDir temp_dir; On 2013/05/28 16:10:43, vandebo wrote: > nit: ...
7 years, 6 months ago (2013-05-29 17:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/15767005/10001
7 years, 6 months ago (2013-05-30 00:08:37 UTC) #4
awong
LGTM
7 years, 6 months ago (2013-05-30 00:11:08 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 01:21:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/15767005/10001
7 years, 6 months ago (2013-05-30 02:09:29 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 05:25:41 UTC) #8
Message was sent while issue was closed.
Change committed as 203086

Powered by Google App Engine
This is Rietveld 408576698