Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2460)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_ui_service.h

Issue 1576493002: Change the Lo-Fi snackbar strings for Lo-Fi preview pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@showLoFiSnackbarNative
Patch Set: newt comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h b/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
index c41779baa54e9f2ad99214f79c57b94c3fa03ac6..34757cb3e138536819d198e79c797e885b98196f 100644
--- a/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
+++ b/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
@@ -24,8 +24,8 @@ class URLRequest;
namespace data_reduction_proxy {
-typedef base::Callback<void(content::WebContents* web_contents)>
- OnLoFiResponseReceivedCallback;
+typedef base::Callback<void(content::WebContents* web_contents,
+ bool is_preview)> OnLoFiResponseReceivedCallback;
// Passes notifications to the UI thread that a Lo-Fi response has been
// received. These notifications may be used to show Lo-Fi UI. This object lives
@@ -38,14 +38,17 @@ class ContentLoFiUIService : public LoFiUIService {
~ContentLoFiUIService() override;
// LoFiUIService implementation:
- void OnLoFiReponseReceived(const net::URLRequest& request) override;
+ void OnLoFiReponseReceived(const net::URLRequest& request,
+ bool is_preview) override;
private:
// Using the |render_process_id| and |render_frame_id|, gets the associated
// WebContents if it exists and runs the
- // |notify_lofi_response_received_callback_|.
+ // |notify_lofi_response_received_callback_|. |is_preview| indicates whether
+ // the response was a Lo-Fi preview response.
void OnLoFiResponseReceivedOnUIThread(int render_process_id,
- int render_frame_id);
+ int render_frame_id,
+ bool is_preview);
// A task runner to post calls to OnLoFiReponseReceivedOnUI on the UI
// thread.

Powered by Google App Engine
This is Rietveld 408576698