Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4821)

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 1576433002: Update doc for r368222: url/title field requires "tabs" permission to be (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/tabs.json
diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json
index 018fe8d1bc00462081db7cc7fe284cf9ef4d25ea..138366d90193f3f1b0780b2842b041e7e1e585d3 100644
--- a/chrome/common/extensions/api/tabs.json
+++ b/chrome/common/extensions/api/tabs.json
@@ -464,7 +464,7 @@
"title": {
"type": "string",
"optional": true,
- "description": "Match page titles against a pattern."
+ "description": "Match page titles against a pattern. Note that this property is ignored if the extension's manifest doesn't include the <code>\"tabs\"</code> permission."
Devlin 2016/01/08 19:38:08 nit: because of activeTab, this isn't 100% true.
lazyboy 2016/01/08 19:57:08 Done.
},
"url": {
"choices": [
@@ -472,7 +472,7 @@
{"type": "array", "items": {"type": "string"}}
],
"optional": true,
- "description": "Match tabs against one or more <a href='match_patterns'>URL patterns</a>. Note that fragment identifiers are not matched."
+ "description": "Match tabs against one or more <a href='match_patterns'>URL patterns</a>. Note that fragment identifiers are not matched. Note that this property is ignored if the extension's manifest doesn't include the <code>\"tabs\"</code> permission."
},
"windowId": {
"type": "integer",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698