src/ia32/lithium-codegen-ia32.cc - Issue 15763004: Replace tagged keys for fast access by smi, and use smi in boundscheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 15763004: Replace tagged keys for fast access by smi, and use smi in boundscheck. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 26e7103466fb22adaac8f23279eb647884616259..3e237638d78e7481d43e14973bb251fd396a5a83 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3364,7 +3364,7 @@ Operand LCodeGen::BuildFastArrayOperand(

+ offset);

} else {

// Take the tag bit into account while computing the shift size.

- if (key_representation.IsTagged() && (shift_size >= 1)) {

+ if (key_representation.IsSmi() && (shift_size >= 1)) {

shift_size -= kSmiTagSize;

}

ScaleFactor scale_factor = static_cast<ScaleFactor>(shift_size);

@@ -4359,7 +4359,7 @@ void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {

if (instr->index()->IsConstantOperand()) {

int constant_index =

ToInteger32(LConstantOperand::cast(instr->index()));

- if (instr->hydrogen()->length()->representation().IsTagged()) {

+ if (instr->hydrogen()->length()->representation().IsSmi()) {

__ cmp(ToOperand(instr->length()),

Immediate(Smi::FromInt(constant_index)));

} else {

« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »