Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 15757013: Remove an experimental webkitInsertionParent API. (Closed)

Created:
7 years, 6 months ago by hayato
Modified:
7 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove an experimental webkitInsertionParent API. As per discussion on the spec, we could remove this experimental API. https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067 BUG=234031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -140 lines) Patch
D LayoutTests/fast/dom/shadow/insertion-parent.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-parent-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-parent-shadow.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-parent-shadow-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-parent-skips-ua-shadow.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-parent-skips-ua-shadow-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hayato
r? Let's remove this API.
7 years, 6 months ago (2013-06-03 05:08:27 UTC) #1
Hajime Morrita
Apparently I'm not a good guy to draw the conclusion :-/
7 years, 6 months ago (2013-06-03 06:55:09 UTC) #2
dglazkov
LGTM.
7 years, 6 months ago (2013-06-03 08:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/15757013/1
7 years, 6 months ago (2013-06-03 08:32:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8372
7 years, 6 months ago (2013-06-03 10:16:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/15757013/1
7 years, 6 months ago (2013-06-04 05:00:06 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 06:05:05 UTC) #7
Message was sent while issue was closed.
Change committed as 151720

Powered by Google App Engine
This is Rietveld 408576698