Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 15757009: Tiny optimization in auto completion of Drive files. (Closed)

Created:
7 years, 7 months ago by kinaba
Modified:
7 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Tiny optimization in auto completion of Drive files. This patch filters out candidates based on the timestamp, before testing filename match or accessing resource metadata DB for file path resolution. BUG=none TEST=With debug build and with a large account, type "a" in the search box of Files.app. It should become faster. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/chromeos/drive/search_metadata.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
May be a non-essential optimization, but at least on my test environment it works quite ...
7 years, 7 months ago (2013-05-27 06:09:41 UTC) #1
hashimoto
lgtm!
7 years, 7 months ago (2013-05-27 06:15:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15757009/1
7 years, 7 months ago (2013-05-27 06:40:40 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 13:03:31 UTC) #4
Message was sent while issue was closed.
Change committed as 202404

Powered by Google App Engine
This is Rietveld 408576698