InstantExtended: better handling of switching between tab and overlay.

InstantExtended: better handling of switching between tab and overlay.

This fixes two issues:
1) Set use_tab_for_suggestions_ at the end of OnAutocompleteStart so that it
doesn't get overridden by calls to HideOverlay.
2) If not using tab for suggestions, make sure the overlay is ready to use.

BUG=241835
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202966

[samarth, 2013-05-23 15:10:37]

I'll try adding a test but I'm not too hopeful given how flaky
UseOverlayIfTabNotReady has been.

Thanks,
Samarth

[samarth, 2013-05-23 15:12:30]

And I'm definitely open to ideas for making this more robust in general!

[sreeram, 2013-05-24 22:47:50]

+rlp: This may fix the extension bug (http://crbug.com/239371), so you may need
to do nothing :)

[sreeram, 2013-05-28 22:31:08]

lgtm

[samarth, 2013-05-29 18:49:23]

Thanks Sreeram.  I'm going to send you a follow-up CL today with more test
coverage for this.

Thanks,
Samarth

[commit-bot: I haz the power, 2013-05-29 18:49:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/15755011/6001

[commit-bot: I haz the power, 2013-05-29 21:05:51]

Change committed as 202966