Issue 15755002: Ignore hardcoded URLs and ForTest(ing)/for_test(ing) in comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15755002: Ignore hardcoded URLs and ForTest(ing)/for_test(ing) in comments. (Closed)

Created:
7 years, 7 months ago by Jói

Modified:
7 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore hardcoded URLs and ForTest(ing)/for_test(ing) in comments. This addresses a couple of bug reports I've received on these presubmit checks. I also fixed how reviewers_plus_owner is created in _CheckAddedDepsHaveTargetApprovals based on comments on a previous patch. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201792

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	PRESUBMIT.py	View		4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/15755002/1

7 years, 7 months ago (2013-05-22 19:59:42 UTC) #3

Message was sent while issue was closed.

Change committed as 201792

Expand Messages | Collapse Messages