Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 1575493004: Blimp: add some hard-coded actions on client startup. (Closed)

Created:
4 years, 11 months ago by Kevin M
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blimp: add some hard-coded actions on client startup. Doing a little bit of work on app startup reduces the need for manual intervention from the developer. BUG= R=dtrainor@chromium.org Committed: https://crrev.com/1ffa52f78c8d333a5e32743c2b1bc2daf1267a13 Cr-Commit-Position: refs/heads/master@{#369243}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove loadUrl from C++ layer #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M blimp/client/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session_android.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M blimp/net/blimp_message_demultiplexer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
David Trainor- moved to gerrit
I would do this in Java so that the UI properly represents what URL we ...
4 years, 11 months ago (2016-01-11 17:46:09 UTC) #1
Kevin M
https://chromiumcodereview.appspot.com/1575493004/diff/1/blimp/client/session/blimp_client_session_android.cc File blimp/client/session/blimp_client_session_android.cc (right): https://chromiumcodereview.appspot.com/1575493004/diff/1/blimp/client/session/blimp_client_session_android.cc#newcode49 blimp/client/session/blimp_client_session_android.cc:49: GetTabControlFeature()->CreateTab(kDummyTabId); On 2016/01/11 17:46:09, David Trainor wrote: > Right ...
4 years, 11 months ago (2016-01-12 01:41:07 UTC) #2
David Trainor- moved to gerrit
WebContenseseses lgtm!
4 years, 11 months ago (2016-01-12 03:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575493004/20001
4 years, 11 months ago (2016-01-12 22:38:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/115993) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-12 22:42:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575493004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575493004/40001
4 years, 11 months ago (2016-01-13 19:07:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-13 19:38:40 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 19:40:05 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1ffa52f78c8d333a5e32743c2b1bc2daf1267a13
Cr-Commit-Position: refs/heads/master@{#369243}

Powered by Google App Engine
This is Rietveld 408576698