Issue 15750002: Send IGNORE feedback to spellcheck service when user cancels spellcheck menu

Issue 15750002: Send IGNORE feedback to spellcheck service when user cancels spellcheck menu (Closed)

Created:
7 years, 7 months ago by please use gerrit instead

Modified:
7 years, 6 months ago

Reviewers:
groby-ooo-7-16, Avi (use Gerrit), commit-bot: I haz the power, Jói

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, rpetterson, jam, rouslan+spellwatch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, groby+spellwatch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Send IGNORE feedback to spellcheck service when user cancels spellcheck menu BUG=170514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202689

Patch Set 1 #

Patch Set 2 : Merge master #

Patch Set 3 : Initialize misspelling hash #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
M	chrome/browser/tab_contents/spelling_menu_observer.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/spelling_menu_observer.cc	View	1 2	3 chunks	+13 lines, -0 lines	0 comments	Download
M	content/public/common/context_menu_params.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

Jói: PTAL content/public/common/context_menu_params.cc Avi: OWNERS PTAL chrome/browser/tab_contents/spelling_menu_observer.{h,cc} Groby: Spellcheck PTAL chrome/browser/tab_contents/spelling_menu_observer.{h,cc}

7 years, 7 months ago (2013-05-24 16:41:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/15750002/32001

7 years, 6 months ago (2013-05-28 17:42:35 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119172

7 years, 6 months ago (2013-05-28 20:03:50 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/15750002/32001

7 years, 6 months ago (2013-05-28 21:33:25 UTC) #7

Message was sent while issue was closed.

Change committed as 202689

Expand Messages | Collapse Messages