Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 15747016: Make cros login error message more descriptive. (Closed)

Created:
7 years, 7 months ago by Tim Song
Modified:
7 years, 7 months ago
Reviewers:
achuithb, nduca, Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make cros login error message more descriptive. When a telemetry test fails to login the test user, the most likely cause is a failure to load the login extension. It is difficult to identify this problem with the old generic timeout error message. BUG=239212 TEST=run_tests with bad --auth-ext-path flag on cros NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201928

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/telemetry/telemetry/core/chrome/cros_util.py View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Tim Song
This is a CL on the telemetry side when the auth extension fails to load. ...
7 years, 7 months ago (2013-05-23 22:23:34 UTC) #1
achuithb
I think this is ok. Nat? https://codereview.chromium.org/15747016/diff/1/tools/telemetry/telemetry/core/chrome/cros_util.py File tools/telemetry/telemetry/core/chrome/cros_util.py (right): https://codereview.chromium.org/15747016/diff/1/tools/telemetry/telemetry/core/chrome/cros_util.py#newcode84 tools/telemetry/telemetry/core/chrome/cros_util.py:84: 'extension passed through ...
7 years, 7 months ago (2013-05-23 22:36:55 UTC) #2
Tim Song
https://codereview.chromium.org/15747016/diff/1/tools/telemetry/telemetry/core/chrome/cros_util.py File tools/telemetry/telemetry/core/chrome/cros_util.py (right): https://codereview.chromium.org/15747016/diff/1/tools/telemetry/telemetry/core/chrome/cros_util.py#newcode84 tools/telemetry/telemetry/core/chrome/cros_util.py:84: 'extension passed through --auth-ext-path is valid and has belongs ...
7 years, 7 months ago (2013-05-23 23:02:33 UTC) #3
nduca
lgtm
7 years, 7 months ago (2013-05-23 23:17:48 UTC) #4
achuithb
lgtm
7 years, 7 months ago (2013-05-23 23:18:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15747016/3
7 years, 7 months ago (2013-05-23 23:20:58 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 23:36:02 UTC) #7
Message was sent while issue was closed.
Change committed as 201928

Powered by Google App Engine
This is Rietveld 408576698