Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 15746004: Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions. (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
Reviewers:
esprehn, apavlov, eseidel
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions. - StylePropertySet::copy() -> mutableCopy() : This function now returns a MutableStylePropertySet, and this is also reflected in the name. - CSSStyleDeclaration::copy() -> copyProperties() : Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration. They also now return MutableStylePropertySets. - StylePropertySet::copyPropertiesInSet() and CSSStyleDeclaration::copyPropertiesInSet() : These functions now return MutableStylePropertySets. This is a backport from WebKit r148365. Patch by Andreas Kling and reviewed by Anders Carlsson. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/WebKitCSSKeyframeRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyledElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
darktears
7 years, 7 months ago (2013-05-22 14:18:41 UTC) #1
eseidel
lgtm Thanks!
7 years, 7 months ago (2013-05-22 19:36:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15746004/1
7 years, 7 months ago (2013-05-22 19:36:51 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 21:02:42 UTC) #4
Message was sent while issue was closed.
Change committed as 150925

Powered by Google App Engine
This is Rietveld 408576698