Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3386)

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.cc

Issue 15745022: Add custom icon support to GlobalError. Show extension icon in permissions increase bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: safety third Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/global_error_bubble_view.cc
diff --git a/chrome/browser/ui/views/global_error_bubble_view.cc b/chrome/browser/ui/views/global_error_bubble_view.cc
index 7046776c56a9c5e0ff8b363159c40d8b38696d34..494bc9fb063f769f71e4258b1a4b40d95ae9f224 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.cc
+++ b/chrome/browser/ui/views/global_error_bubble_view.cc
@@ -70,9 +70,13 @@ GlobalErrorBubbleView::GlobalErrorBubbleView(
gfx::Insets(kAnchorVerticalInset, 0, kAnchorVerticalInset, 0));
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- int resource_id = error_->GetBubbleViewIconResourceID();
+ gfx::Image* image = error_->GetBubbleViewCustomIcon();
+ if (!image) {
+ int resource_id = error_->GetBubbleViewIconResourceID();
+ image = &rb.GetNativeImageNamed(resource_id);
+ }
scoped_ptr<views::ImageView> image_view(new views::ImageView());
- image_view->SetImage(rb.GetImageNamed(resource_id).ToImageSkia());
+ image_view->SetImage(image->ToImageSkia());
string16 title_string(error_->GetBubbleViewTitle());
scoped_ptr<views::Label> title_label(new views::Label(title_string));
« chrome/browser/ui/global_error/global_error.h ('K') | « chrome/browser/ui/gtk/global_error_bubble.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698