Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 15745017: Fix the commandline handling in quic_client. (Closed)

Created:
7 years, 7 months ago by honghaiz
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Matt Welsh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the commandline handling in quic_client. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202009

Patch Set 1 #

Total comments: 2

Patch Set 2 : "Revised comments" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M net/tools/quic/quic_client_bin.cc View 1 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
honghaiz
7 years, 7 months ago (2013-05-22 21:13:45 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/15745017/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/15745017/diff/1/net/tools/quic/quic_client_bin.cc#newcode6 net/tools/quic/quic_client_bin.cc:6: // --port and requests URLs specified on the ...
7 years, 7 months ago (2013-05-22 22:56:08 UTC) #2
Ryan Hamilton
lgtm, as well
7 years, 7 months ago (2013-05-23 16:27:20 UTC) #3
honghaiz
https://codereview.chromium.org/15745017/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/15745017/diff/1/net/tools/quic/quic_client_bin.cc#newcode6 net/tools/quic/quic_client_bin.cc:6: // --port and requests URLs specified on the command ...
7 years, 7 months ago (2013-05-23 16:59:08 UTC) #4
ramant (doing other things)
lgtm
7 years, 7 months ago (2013-05-23 17:05:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/honghaiz@chromium.org/15745017/6001
7 years, 7 months ago (2013-05-23 20:09:09 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 07:32:17 UTC) #7
Message was sent while issue was closed.
Change committed as 202009

Powered by Google App Engine
This is Rietveld 408576698