Issue 15745006: Don't allow copying holes to fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15745006: Don't allow copying holes to fields. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't allow copying holes to fields. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14753

Patch Set 2 : Fix test #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-copy-hole-to-field.js	View	1	1 chunk	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments, and if it doesn't cause unexpected deopts/regressions. https://chromiumcodereview.appspot.com/15745006/diff/1/test/mjsunit/regress/regress-copy-hole-to-field.js File test/mjsunit/regress/regress-copy-hole-to-field.js (right): https://chromiumcodereview.appspot.com/15745006/diff/1/test/mjsunit/regress/regress-copy-hole-to-field.js#newcode42 ...

7 years, 7 months ago (2013-05-22 15:28:09 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-22 15:34:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14753 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15745006: Don't allow copying holes to fields. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix test #

Messages