Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 15744007: Merged r14751, r14753 into trunk branch. (Closed)

Created:
7 years, 7 months ago by ulan
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Merged r14751, r14753 into trunk branch. Fix Windows shared library build. Don't allow copying holes to fields. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M include/v8.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-copy-hole-to-field.js View 1 chunk +26 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
7 years, 7 months ago (2013-05-22 15:41:09 UTC) #1
Toon Verwaest
lgtm
7 years, 7 months ago (2013-05-22 15:42:15 UTC) #2
ulan
7 years, 7 months ago (2013-05-22 15:42:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698