Fix potential NULL pointer in LayerTreeHostImpl

Fix potential NULL pointer in LayerTreeHostImpl

When using tile-free renderering, if ActivationStateAsValue() is called
when there is a pending tree it would hit a NULL pointer on tile_manager_.


BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202008

[joth, 2013-05-23 01:37:10]

I had to remove the DCHECK to be able to effectively test this, but AFAICT doing
so is benign.
(I tried calling CreatePendingTree() to be able to push AsValue() down into the
ActivationStateAsValue() but that hit more snags in the pending tree itself not
having a proxy, and started to feel too brittle a test. let me know if you have
other suggestions though)

[enne (OOO), 2013-05-23 01:56:06]

lgtm

[commit-bot: I haz the power, 2013-05-23 01:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/15743022/1

[danakj, 2013-05-23 14:25:54]

https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl.cc
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:2211: state->Set("tile_manager", tile_manager_
?
Other places (AsValue() above this) just don't set a value when the thing is
missing. Can we do the same here instead of setting NULL?

[commit-bot: I haz the power, 2013-05-23 19:15:25]

List of reviewers changed. danakj@chromium.org did a drive-by without LGTM'ing!

[joth, 2013-05-23 19:46:17]

https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl.cc
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:2211: state->Set("tile_manager", tile_manager_
?
On 2013/05/23 14:25:54, danakj wrote:
> Other places (AsValue() above this) just don't set a value when the thing is
> missing. Can we do the same here instead of setting NULL?

Done.

[danakj, 2013-05-23 20:00:03]

On 2013/05/23 19:46:17, joth wrote:
>
https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl.cc
> File cc/trees/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/15743022/diff/1/cc/trees/layer_tree_host_impl...
> cc/trees/layer_tree_host_impl.cc:2211: state->Set("tile_manager",
tile_manager_
> ?
> On 2013/05/23 14:25:54, danakj wrote:
> > Other places (AsValue() above this) just don't set a value when the thing is
> > missing. Can we do the same here instead of setting NULL?
> 
> Done.

Cool thanks. (Sorry didn't see the previous lgtm at the time)

[danakj, 2013-05-23 20:00:12]

LGTM tho :)

[commit-bot: I haz the power, 2013-05-23 21:31:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/15743022/26001

[commit-bot: I haz the power, 2013-05-24 07:31:53]

Change committed as 202008