src/hydrogen.cc - Issue 15743006: Improve SeqStringSetChar implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 15743006: Improve SeqStringSetChar implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: small fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index f25efbfbc3e44bdbaf7b84cf156fef687584967f..3680ca1fea744b78cf75500937307d4817e2c909 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -11461,9 +11461,6 @@ void HOptimizedGraphBuilder::GenerateTwoByteSeqStringSetChar(

HValue* value = Pop();

HValue* index = Pop();

HValue* string = Pop();

- HValue* context = environment()->LookupContext();

- HInstruction* char_code = BuildStringCharCodeAt(context, string, index);

- AddInstruction(char_code);

HSeqStringSetChar* result = new(zone()) HSeqStringSetChar(

String::TWO_BYTE_ENCODING, string, index, value);

return ast_context()->ReturnInstruction(result, call->id());

« no previous file with comments | « src/full-codegen.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »