Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 15743006: Improve SeqStringSetChar implementation. (Closed)

Created:
7 years, 7 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Improve SeqStringSetChar implementation. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14769

Patch Set 1 #

Patch Set 2 : platform ports #

Total comments: 2

Patch Set 3 : small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -189 lines) Patch
M src/arm/codegen-arm.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 chunks +60 lines, -10 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +28 lines, -5 lines 0 comments Download
M src/codegen.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/full-codegen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 chunks +59 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +26 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 chunks +55 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +26 lines, -5 lines 0 comments Download
M test/mjsunit/string-fromcharcode.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
7 years, 7 months ago (2013-05-22 15:40:17 UTC) #1
Jakob Kummerow
Looks good so far, go ahead with the platform ports. Also, you can remove the ...
7 years, 7 months ago (2013-05-22 16:25:51 UTC) #2
Yang
On 2013/05/22 16:25:51, Jakob wrote: > Looks good so far, go ahead with the platform ...
7 years, 7 months ago (2013-05-23 09:27:23 UTC) #3
Jakob Kummerow
Almost LGTM. https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1688 src/x64/lithium-codegen-x64.cc:1688: __ SmiToInteger32(value, value); No. https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1689 src/x64/lithium-codegen-x64.cc:1689: __ ...
7 years, 7 months ago (2013-05-23 09:35:45 UTC) #4
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-23 09:50:06 UTC) #5
Yang
7 years, 7 months ago (2013-05-23 09:51:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r14769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698