Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2231)

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 15742019: Avoid DidStopLoading messages from the old renderer process during a transfer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clarify comment. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/app_process_apitest.cc
diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc
index 811d94d81ec0f2c5e10cf5fd48c46c33381480f1..0d401694aa5398952d15cbd2d3bbfde39367e439 100644
--- a/chrome/browser/extensions/app_process_apitest.cc
+++ b/chrome/browser/extensions/app_process_apitest.cc
@@ -671,13 +671,13 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, OpenAppFromExtension) {
const Extension* launcher =
LoadExtension(test_data_dir_.AppendASCII("app_launcher"));
- // There should be three navigations by the time the app page is loaded.
+ // There should be two navigations by the time the app page is loaded.
// 1. The extension launcher page.
- // 2. The URL that the extension launches, which redirects.
- // 3. The app's URL.
+ // 2. The app's URL (which includes a server redirect).
+ // Note that the server redirect does not generate a navigation event.
content::TestNavigationObserver test_navigation_observer(
content::NotificationService::AllSources(),
- 3);
+ 2);
// Load the launcher extension, which should launch the app.
ui_test_utils::NavigateToURLWithDisposition(
« no previous file with comments | « no previous file | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698