Issue 15742019: Avoid DidStopLoading messages from the old renderer process during a transfer.

Issue 15742019: Avoid DidStopLoading messages from the old renderer process during a transfer. (Closed)

Created:
7 years, 7 months ago by Charlie Reis

Modified:
7 years, 6 months ago

Reviewers:
Matt Perry, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoid DidStopLoading messages from the old renderer process during a transfer. BUG=243957 TEST=BrowserTest.NoStopDuringTransferUntilCommit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202904

Patch Set 1 : Initial patch. #

Patch Set 2 : Fix assumption in test #

Total comments: 2

Patch Set 3 : Clarify comment. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -18 lines)			Patch
M	chrome/browser/extensions/app_process_apitest.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View		3 chunks	+43 lines, -5 lines	0 comments	Download
M	chrome/test/data/beforeunload.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Matt, can you take a look? We were generating some stop events during transfers that ...

7 years, 6 months ago (2013-05-28 22:04:42 UTC) #1

Matt Perry

LGTM, nice fix. https://codereview.chromium.org/15742019/diff/7001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/15742019/diff/7001/content/renderer/render_view_impl.cc#newcode5481 content/renderer/render_view_impl.cc:5481: // filtering the IPCs. We don't ...

7 years, 6 months ago (2013-05-28 22:08:06 UTC) #2

Charlie Reis

Thanks! Comment updated. Scott, can you look at chrome/browser/ui/browser_browsertest.cc for owners approval? https://codereview.chromium.org/15742019/diff/7001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc ...

7 years, 6 months ago (2013-05-28 22:17:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/15742019/13001

7 years, 6 months ago (2013-05-29 16:08:24 UTC) #5

Message was sent while issue was closed.

Change committed as 202904

Expand Messages | Collapse Messages