[sync] Fix incorrectly grayed out "Disconnect your Google Account..." button

[sync] Fix incorrectly grayed out "Disconnect your Google Account..." button

The "Disconnect your Google Account..." button in the settings page is
supposed to be grayed out when sync setup is in progress, as indicated
by ProfileSyncService::setup_in_progress_. Earlier, we were calling
ProfileSyncService::SetSetupInProgress(false) under all circumstances
from SyncSetupHandler::CloseSyncSetup(), but with r200867, we missed out
on setting the value to false under some conditions. One example of the
flag incorrectly remaining set to true occurs when the user enables
encryption with a custom passphrase and then clears sync data via the
dashboard.

This patch adds a call to ProfileSyncService::SetSetupInProgress(false)
from SyncSetupHandler::CloseSyncSetup() irrespective of why the settings
dialog was closed.

BUG=243078
TEST=Enable custom encryption, do a dashboard clear, and check the settings page

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202006

[Raghu Simha, 2013-05-22 23:05:42]

Drew, please review. Thanks.

[Raghu Simha, 2013-05-23 17:51:09]

Looks like Drew is out. Roger, could you please review this?

[Raghu Simha, 2013-05-23 20:56:14]

Looks like Roger is out too. Nicolas, could you take a look? Thanks.

[Nicolas Zea, 2013-05-23 20:58:40]

lgtm

[Nicolas Zea, 2013-05-23 20:59:13]

On 2013/05/23 20:58:40, Nicolas Zea wrote:
> lgtm

That said, I don't have ownership of this file

[Roger Tawa OOO till Jul 10th, 2013-05-23 21:00:40]

lgtm

[commit-bot: I haz the power, 2013-05-23 21:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsimha@chromium.org/15742014/8001

[commit-bot: I haz the power, 2013-05-24 07:25:15]

Change committed as 202006