Issue 15742012: pull constant out of trace_event_impl for split_link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15742012: pull constant out of trace_event_impl for split_link (Closed)

Created:
7 years, 7 months ago by scottmg

Modified:
7 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

pull constant out of trace_event_impl for split_link trace_event_impl contains Singleton usage, so had to be separated. Last one! TBR=brettw@chromium.org R=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201714

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	base/base.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/debug/trace_event_impl.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A	base/debug/trace_event_impl_constants.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	build/split_link_partition.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15742012/3001

7 years, 7 months ago (2013-05-22 23:27:34 UTC) #2

Message was sent while issue was closed.

Change committed as 201714