Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 15742002: Use the default 'component' setting for Mac ASan builds (i.e. 'shared_library') (Closed)

Created:
7 years, 7 months ago by Alexander Potapenko
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use the default 'component' setting for Mac ASan builds (i.e. 'shared_library') This had become possible after the switch to ASan dynamic runtime. BUG=145503 R=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
PTAL
7 years, 7 months ago (2013-05-22 12:30:20 UTC) #1
Nico
lgtm
7 years, 6 months ago (2013-05-29 20:57:53 UTC) #2
Nico
Not sure if the red mac_asan bot on this CL is related to the CL.
7 years, 6 months ago (2013-05-31 21:44:32 UTC) #3
Alexander Potapenko
It isn't. I was just using it to trigger the mac_asan failures. Sent from phone ...
7 years, 6 months ago (2013-06-01 12:38:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/15742002/1
7 years, 6 months ago (2013-06-02 18:44:37 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-02 21:25:15 UTC) #6
Message was sent while issue was closed.
Change committed as 203628

Powered by Google App Engine
This is Rietveld 408576698