Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 15741014: Fix WebViewTest.MediaAccessAPIAllow* flakiness/timeout on chromeos. (Closed)

Created:
7 years, 7 months ago by lazyboy
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix WebViewTest.MediaAccessAPIAllow* flakiness/timeout on chromeos. Split the individual tests, this was timing out occasionally otherwise on linux_chromeos build bots. BUG=238662 TEST=WebViewTest.MediaAccessAPIAllow, verified timeout is fixed by running each tests 200 times on trybots, tests now do not flake. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202031

Patch Set 1 #

Patch Set 2 : Split allow tests nows. #

Patch Set 3 : Ready for review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -47 lines) Patch
M chrome/browser/extensions/web_view_browsertest.cc View 1 2 3 chunks +27 lines, -30 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/media_access/allow/embedder.js View 1 2 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lazyboy
Verified flakiness is fixed: w/o the change, 200 runs cause flakiness: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/117479 /w the change, ...
7 years, 7 months ago (2013-05-23 07:32:21 UTC) #1
sky
Rubber stamp LGTM
7 years, 7 months ago (2013-05-23 15:43:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/15741014/6001
7 years, 7 months ago (2013-05-23 16:18:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=43217
7 years, 7 months ago (2013-05-24 00:45:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/15741014/6001
7 years, 7 months ago (2013-05-24 04:34:17 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 09:31:26 UTC) #6
Message was sent while issue was closed.
Change committed as 202031

Powered by Google App Engine
This is Rietveld 408576698