Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 15741003: Moving WebRTC logging related files from content to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed some errors. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_dependency_factory.cc
diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc
index 5b9d022dc7977dbc17c33ac3f5233c7f22b51114..798dc19926ddedd7d34a84b69968f72f47563817 100644
--- a/content/renderer/media/media_stream_dependency_factory.cc
+++ b/content/renderer/media/media_stream_dependency_factory.cc
@@ -18,8 +18,6 @@
#include "content/renderer/media/webaudio_capturer_source.h"
#include "content/renderer/media/webrtc_audio_device_impl.h"
#include "content/renderer/media/webrtc_local_audio_track.h"
-#include "content/renderer/media/webrtc_logging_handler_impl.h"
-#include "content/renderer/media/webrtc_logging_message_filter.h"
#include "content/renderer/media/webrtc_uma_histograms.h"
#include "content/renderer/p2p/ipc_network_manager.h"
#include "content/renderer/p2p/ipc_socket_factory.h"
@@ -40,10 +38,6 @@
namespace content {
-// The constraint key for the PeerConnection constructor for enabling diagnostic
-// WebRTC logging. It's a Google specific key, hence the "goog" prefix.
-const char kWebRtcLoggingConstraint[] = "googLog";
-
// Constant constraint keys which disables all audio constraints.
// Only used in combination with WebAudio sources.
struct {
@@ -215,8 +209,7 @@ MediaStreamDependencyFactory::MediaStreamDependencyFactory(
p2p_socket_dispatcher_(p2p_socket_dispatcher),
signaling_thread_(NULL),
worker_thread_(NULL),
- chrome_worker_thread_("Chrome_libJingle_WorkerThread"),
- webrtc_log_open_(false) {
+ chrome_worker_thread_("Chrome_libJingle_WorkerThread") {
}
MediaStreamDependencyFactory::~MediaStreamDependencyFactory() {
@@ -501,22 +494,6 @@ MediaStreamDependencyFactory::CreatePeerConnection(
CHECK(web_frame);
CHECK(observer);
- webrtc::MediaConstraintsInterface::Constraints optional_constraints =
- constraints->GetOptional();
- std::string constraint_value;
- if (!webrtc_log_open_ &&
- optional_constraints.FindFirst(kWebRtcLoggingConstraint,
- &constraint_value)) {
- webrtc_log_open_ = true;
-
- RenderThreadImpl::current()->GetIOMessageLoopProxy()->PostTask(
- FROM_HERE, base::Bind(
- &MediaStreamDependencyFactory::CreateWebRtcLoggingHandler,
- base::Unretained(this),
- RenderThreadImpl::current()->webrtc_logging_message_filter(),
- constraint_value));
- }
-
scoped_refptr<P2PPortAllocatorFactory> pa_factory =
new talk_base::RefCountedObject<P2PPortAllocatorFactory>(
p2p_socket_dispatcher_.get(),
@@ -787,12 +764,4 @@ void MediaStreamDependencyFactory::CleanupPeerConnectionFactory() {
}
}
-void MediaStreamDependencyFactory::CreateWebRtcLoggingHandler(
- WebRtcLoggingMessageFilter* filter,
- const std::string& app_session_id) {
- WebRtcLoggingHandlerImpl* handler =
- new WebRtcLoggingHandlerImpl(filter->io_message_loop());
- filter->InitLogging(handler, app_session_id);
-}
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698