Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: content/public/renderer/media/webrtc_log_message_delegate.h

Issue 15741003: Moving WebRTC logging related files from content to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changing log message delegation path to go via content. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_tests.gypi ('k') | content/public/renderer/media/webrtc_logging_initializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/media/webrtc_log_message_delegate.h
diff --git a/content/public/renderer/media/webrtc_log_message_delegate.h b/content/public/renderer/media/webrtc_log_message_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..dfbde273bcf094e80641b1918599b7946b12178d
--- /dev/null
+++ b/content/public/renderer/media/webrtc_log_message_delegate.h
@@ -0,0 +1,28 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_LOG_MESSAGE_DELEGATE_H_
+#define CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_LOG_MESSAGE_DELEGATE_H_
+
+#include <string>
+
+namespace content {
+
+// This interface is implemented by a handler in the embedder and used for
+// initializing the logging and passing log messages to the handler. The
+// purpose is to forward mainly libjingle log messages to Chrome (besides to the
jam 2013/05/29 16:25:48 nit: don't mention chrome in content
Henrik Grunell 2013/05/29 16:56:59 Changed to "embedder".
+// ordinary logging stream) that will be used for diagnostic purposes.
+class WebRtcLogMessageDelegate {
+ public:
+ virtual void InitLogging(const std::string& app_session_id,
+ const std::string& app_url) = 0;
jam 2013/05/29 16:25:48 what are these two parameters? nit: also document
Henrik Grunell 2013/05/29 16:56:59 The app session ID comes from the constraint value
+ virtual void LogMessage(const std::string& message) = 0;
+
+ protected:
+ virtual ~WebRtcLogMessageDelegate() {}
+};
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_LOG_MESSAGE_DELEGATE_H_
« no previous file with comments | « content/content_tests.gypi ('k') | content/public/renderer/media/webrtc_logging_initializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698