chrome/renderer/DEPS - Issue 15741003: Moving WebRTC logging related files from content to chrome.

Side by Side Diff: chrome/renderer/DEPS

Issue 15741003: Moving WebRTC logging related files from content to chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Public content API for setting the log delegate. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/common/partial_circular_buffer_unittest.cc ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | chrome/renderer/chrome_content_renderer_client.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+chrome/app", # The plugins use the theme library to get the sad plugin bitm ap.	2 "+chrome/app", # The plugins use the theme library to get the sad plugin bitm ap.

3 "+components/autofill/common",	3 "+components/autofill/common",

4 "+components/autofill/renderer",	4 "+components/autofill/renderer",

5 "+components/visitedlink/renderer",	5 "+components/visitedlink/renderer",

6 "+content/public/renderer",	6 "+content/public/renderer",

7 "+extensions/common",	7 "+extensions/common",

8 "+grit", # For generated headers	8 "+grit", # For generated headers

9 "+media/base", # For initializing media library and media switches.	9 "+media/base", # For initializing media library and media switches.

10 "+ppapi/native_client/src/trusted/plugin/nacl_entry_points.h", # For NaCl reg istration.	10 "+ppapi/native_client/src/trusted/plugin/nacl_entry_points.h", # For NaCl reg istration.

11 "+ppapi/c",	11 "+ppapi/c",

12 "+ppapi/proxy",	12 "+ppapi/proxy",

13 "+ppapi/shared_impl",	13 "+ppapi/shared_impl",

14 "+sandbox/win/src",	14 "+sandbox/win/src",

15 "+skia",	15 "+skia",

16	16

17 "+webkit/fileapi",	17 "+webkit/fileapi",

18 "+webkit/glue",	18 "+webkit/glue",

19 "+webkit/glue/plugins",	19 "+webkit/glue/plugins",

20 "+webkit/media",	20 "+webkit/media",

21 "+webkit/plugins",	21 "+webkit/plugins",

22	22

23 "+third_party/cld/encodings/compact_lang_det/win",	23 "+third_party/cld/encodings/compact_lang_det/win",

	24 "+third_party/libjingle",
	tommi (sloooow) - chröme 2013/05/24 16:27:49 Hej Henrik - I think we should revert this. Chrom Hej Henrik - I think we should revert this. Chrome shouldn't depend on libjingle. #including stuff from the overrides/ folder is a gray area though since strictly speaking it "may" not be a part of libjingle itself (such as in the case of the header you're including). Henrik Grunell 2013/05/24 18:26:02 Agree. I'll revert this when we have settled on th Show quoted text On 2013/05/24 16:27:49, tommi wrote: > Hej Henrik - I think we should revert this. Chrome shouldn't depend on > libjingle. #including stuff from the overrides/ folder is a gray area though > since strictly speaking it "may" not be a part of libjingle itself (such as in > the case of the header you're including). Agree. I'll revert this when we have settled on the other details and I make the changes for a new patch. Henrik Grunell 2013/05/27 16:23:06 Actually, the handler includes the delegate interf Show quoted text On 2013/05/24 18:26:02, Henrik Grunell wrote: > On 2013/05/24 16:27:49, tommi wrote: > > Hej Henrik - I think we should revert this. Chrome shouldn't depend on > > libjingle. #including stuff from the overrides/ folder is a gray area though > > since strictly speaking it "may" not be a part of libjingle itself (such as in > > the case of the header you're including). > > Agree. I'll revert this when we have settled on the other details and I make the > changes for a new patch. Actually, the handler includes the delegate interface since it implements it. So I've kept it, but it would be nice to not have this. The alternative I see is to wrap the interface in content but that's not very nice either. Jói 2013/05/27 17:50:03 I'd suggest at least narrowing it down to just the Show quoted text On 2013/05/27 16:23:06, Henrik Grunell wrote: > On 2013/05/24 18:26:02, Henrik Grunell wrote: > > On 2013/05/24 16:27:49, tommi wrote: > > > Hej Henrik - I think we should revert this. Chrome shouldn't depend on > > > libjingle. #including stuff from the overrides/ folder is a gray area > though > > > since strictly speaking it "may" not be a part of libjingle itself (such as > in > > > the case of the header you're including). > > > > Agree. I'll revert this when we have settled on the other details and I make > the > > changes for a new patch. > > Actually, the handler includes the delegate interface since it implements it. So > I've kept it, but it would be nice to not have this. The alternative I see is to > wrap the interface in content but that's not very nice either. I'd suggest at least narrowing it down to just the one header you actually need. Henrik Grunell 2013/05/28 06:04:29 Of course. Done. Show quoted text On 2013/05/27 17:50:03, Jói wrote: > On 2013/05/27 16:23:06, Henrik Grunell wrote: > > On 2013/05/24 18:26:02, Henrik Grunell wrote: > > > On 2013/05/24 16:27:49, tommi wrote: > > > > Hej Henrik - I think we should revert this. Chrome shouldn't depend on > > > > libjingle. #including stuff from the overrides/ folder is a gray area > > though > > > > since strictly speaking it "may" not be a part of libjingle itself (such > as > > in > > > > the case of the header you're including). > > > > > > Agree. I'll revert this when we have settled on the other details and I make > > the > > > changes for a new patch. > > > > Actually, the handler includes the delegate interface since it implements it. > So > > I've kept it, but it would be nice to not have this. The alternative I see is > to > > wrap the interface in content but that's not very nice either. > > I'd suggest at least narrowing it down to just the one header you actually need. Of course. Done.
24 "+third_party/npapi/bindings",	25 "+third_party/npapi/bindings",

25 "+third_party/re2",	26 "+third_party/re2",

26 "+third_party/smhasher",	27 "+third_party/smhasher",

27 "+third_party/sqlite",	28 "+third_party/sqlite",

28 "+third_party/widevine",	29 "+third_party/widevine",

29 ]	30 ]

OLD	NEW