Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 15737007: Make more GCs in idle notification handler. (Closed)

Created:
7 years, 7 months ago by ulan
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make more GCs in idle notification handler. When counting GCs in idle round, count only GC that were directly triggered by the idle notification handler. R=hpayer@chromium.org BUG=241815 Committed: https://code.google.com/p/v8/source/detail?r=14879

Patch Set 1 #

Patch Set 2 : Correctly finish idle round. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/heap.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap.cc View 1 5 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
7 years, 7 months ago (2013-05-22 14:42:02 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 7 months ago (2013-05-22 15:32:50 UTC) #2
ulan
Uploaded new patch set with minor fix to ensure that we finish an idle round.
7 years, 7 months ago (2013-05-27 10:51:35 UTC) #3
ulan
7 years, 6 months ago (2013-05-29 11:45:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698