Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 15737003: Handle holes in smi-untag from LoadKeyed requiring hole handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Respect hole-mode Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1882 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 LOperand* value = UseRegister(instr->value()); 1893 LOperand* value = UseRegister(instr->value());
1894 LNumberUntagD* res = new(zone()) LNumberUntagD(value); 1894 LNumberUntagD* res = new(zone()) LNumberUntagD(value);
1895 return AssignEnvironment(DefineAsRegister(res)); 1895 return AssignEnvironment(DefineAsRegister(res));
1896 } else { 1896 } else {
1897 ASSERT(to.IsInteger32()); 1897 ASSERT(to.IsInteger32());
1898 LOperand* value = NULL; 1898 LOperand* value = NULL;
1899 LInstruction* res = NULL; 1899 LInstruction* res = NULL;
1900 if (instr->value()->type().IsSmi()) { 1900 if (instr->value()->type().IsSmi()) {
1901 value = UseRegisterAtStart(instr->value()); 1901 value = UseRegisterAtStart(instr->value());
1902 res = DefineAsRegister(new(zone()) LSmiUntag(value, false)); 1902 res = DefineAsRegister(new(zone()) LSmiUntag(value, false));
1903 if (instr->value()->IsLoadKeyed()) {
1904 HLoadKeyed* load_keyed = HLoadKeyed::cast(instr->value());
1905 if (load_keyed->UsesMustHandleHole() &&
1906 load_keyed->hole_mode() == NEVER_RETURN_HOLE) {
1907 res = AssignEnvironment(res);
1908 }
1909 }
1903 } else { 1910 } else {
1904 value = UseRegister(instr->value()); 1911 value = UseRegister(instr->value());
1905 LOperand* temp1 = TempRegister(); 1912 LOperand* temp1 = TempRegister();
1906 LOperand* temp2 = instr->CanTruncateToInt32() ? TempRegister() 1913 LOperand* temp2 = instr->CanTruncateToInt32() ? TempRegister()
1907 : NULL; 1914 : NULL;
1908 LOperand* temp3 = FixedTemp(d11); 1915 LOperand* temp3 = FixedTemp(d11);
1909 res = DefineSameAsFirst(new(zone()) LTaggedToI(value, 1916 res = DefineSameAsFirst(new(zone()) LTaggedToI(value,
1910 temp1, 1917 temp1,
1911 temp2, 1918 temp2,
1912 temp3)); 1919 temp3));
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
2608 2615
2609 2616
2610 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2617 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2611 LOperand* object = UseRegister(instr->object()); 2618 LOperand* object = UseRegister(instr->object());
2612 LOperand* index = UseRegister(instr->index()); 2619 LOperand* index = UseRegister(instr->index());
2613 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2620 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2614 } 2621 }
2615 2622
2616 2623
2617 } } // namespace v8::internal 2624 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698