Issue 15737003: Handle holes in smi-untag from LoadKeyed requiring hole handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15737003: Handle holes in smi-untag from LoadKeyed requiring hole handling. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handle holes in smi-untag from LoadKeyed requiring hole handling. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14756

Patch Set 2 : Respect hole-mode #

Created: 7 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -6 lines)
M	src/arm/lithium-arm.h	View	1 chunk	+1 line, -0 lines	0 comments
M	src/arm/lithium-arm.cc	View	1 chunk	+7 lines, -0 lines	0 comments
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+15 lines, -0 lines	0 comments
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+19 lines, -3 lines	0 comments
M	src/ia32/lithium-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments
M	src/ia32/lithium-ia32.cc	View	1 chunk	+10 lines, -1 line	0 comments
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+15 lines, -0 lines	0 comments
M	src/x64/lithium-x64.h	View	1 chunk	+1 line, -0 lines	0 comments
M	src/x64/lithium-x64.cc	View	1 chunk	+10 lines, -1 line	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

https://chromiumcodereview.appspot.com/15737003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/15737003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode5036 src/ia32/lithium-codegen-ia32.cc:5036: if (load->UsesMustHandleHole()) { As discussed offline, I think you ...

7 years, 7 months ago (2013-05-22 14:06:07 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-22 16:32:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14756 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15737003: Handle holes in smi-untag from LoadKeyed requiring hole handling. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Respect hole-mode #

Messages