Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 15736012: Send ADD_TO_DICT feedback to spelling service when user adds word to dictionary (Closed)

Created:
7 years, 7 months ago by please use gerrit instead
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, rpetterson, jam, rouslan+spellwatch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, groby+spellwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Send ADD_TO_DICT feedback to spelling service when user adds word to dictionary When a user of the spelling service right-clicks on a misspelled word and selects 'Add to dictionary', the SpellingMenuObserver notifies spelling service feedback sender. This feedback will be used to improve spellcheck suggestions from spelling service. BUG=170514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202938

Patch Set 1 #

Patch Set 2 : Merge master #

Patch Set 3 : Merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
please use gerrit instead
Groby: Spellcheck PTAL. Avi: OWNERS PTAL.
7 years, 6 months ago (2013-05-29 00:36:12 UTC) #1
Avi (use Gerrit)
lgtm owner happy
7 years, 6 months ago (2013-05-29 00:59:55 UTC) #2
groby-ooo-7-16
lgtm
7 years, 6 months ago (2013-05-29 03:04:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/15736012/30001
7 years, 6 months ago (2013-05-29 16:10:02 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 19:40:07 UTC) #5
Message was sent while issue was closed.
Change committed as 202938

Powered by Google App Engine
This is Rietveld 408576698