Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15734030: Remove support for device-width|height for @viewport rule according to spec change (Closed)

Created:
7 years, 6 months ago by kenneth.r.christiansen
Modified:
7 years, 6 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, kenneth.christiansen, darktears
Visibility:
Public.

Description

Remove support for device-width|height for @viewport rule according to spec change Also update the tests and unskip as they are now passing Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152337

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Removed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -610 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-007-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-at-rule-parsing.html View 2 chunks +0 lines, -11 lines 0 comments Download
A LayoutTests/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-properties-validation.html View 2 chunks +0 lines, -4 lines 0 comments Download
A LayoutTests/css3/device-adapt/viewport-properties-validation-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
D LayoutTests/platform/chromium-linux-x86/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-linux-x86/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-linux/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-linux/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-mac-snowleopard/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-mac-snowleopard/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-mac/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-mac/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-win-xp/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-win-xp/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/chromium-win/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/chromium-win/css3/device-adapt/viewport-properties-validation-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kenneth.r.christiansen
7 years, 6 months ago (2013-06-12 14:51:44 UTC) #1
rune
lgtm with nit https://codereview.chromium.org/15734030/diff/4001/Source/core/css/CSSValueKeywords.in File Source/core/css/CSSValueKeywords.in (left): https://codereview.chromium.org/15734030/diff/4001/Source/core/css/CSSValueKeywords.in#oldcode795 Source/core/css/CSSValueKeywords.in:795: device-height Remove the comments above, too?
7 years, 6 months ago (2013-06-12 16:30:50 UTC) #2
kenneth.r.christiansen
> https://codereview.chromium.org/15734030/diff/4001/Source/core/css/CSSValueKeywords.in#oldcode795 > Source/core/css/CSSValueKeywords.in:795: device-height > Remove the comments above, too? I am not sure... ...
7 years, 6 months ago (2013-06-12 16:33:21 UTC) #3
rune
On 2013/06/12 16:33:21, kenneth.r.christiansen wrote: > > > https://codereview.chromium.org/15734030/diff/4001/Source/core/css/CSSValueKeywords.in#oldcode795 > > Source/core/css/CSSValueKeywords.in:795: device-height > > ...
7 years, 6 months ago (2013-06-12 17:11:34 UTC) #4
kenneth.r.christiansen
OK, I removed the comment Rune.
7 years, 6 months ago (2013-06-12 23:17:33 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 6 months ago (2013-06-13 08:20:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15734030/15001
7 years, 6 months ago (2013-06-13 08:31:39 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 09:36:18 UTC) #8
Message was sent while issue was closed. 
Change committed as 152337

Powered by Google App Engine
This is Rietveld 408576698