Split token-related methods from WebDataService

Split token-related methods from WebDataService

These are only used bu Signin/ and will move into the sign-in component once it gets created.

TBR=atwilson@chromium.org,ben@chromium.org 
BUG=233552
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202463

[Cait (Slow), 2013-05-23 00:26:21]

Hi Jói,

This is a first step towards splitting the Sign-in related bits of Webdata off
from the rest of WebData.

This change will put us at 3 WebDatas per profile...do you think it still makes
sense to have a wrapper class managing all access to them as we do now, or
should we move to something a bit less clunky?

Cheers,
Cait

[Jói, 2013-05-23 17:58:08]

LGTM with nits.

I don't mind the clunky factory, at least not for this change. If we switch from
that model it will likely be a change in semantics (not all WebData subclasses
get instantiated at the same time) but that's likely fine.

Cheers,
Jói

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
File chrome/browser/webdata/token_web_data.cc (right):

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
2013, and no (c)

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
File chrome/browser/webdata/token_web_data.h (right):

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
2013, no (c)

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.h:33: class TokenWebData : public
WebDataServiceBase {
Maybe one line of documentation? e.g. "Storage for authentication tokens."

[Cait (Slow), 2013-05-24 16:17:08]

rogerta: PTAL at chrome/browser/signin changes. (Mostly just switching instances
of WebDataService over to TokenWebData)

Thanks,
Cait

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
File chrome/browser/webdata/token_web_data.cc (right):

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2013/05/23 17:58:08, Jói wrote:
> 2013, and no (c)

Done.

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
File chrome/browser/webdata/token_web_data.h (right):

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2013/05/23 17:58:08, Jói wrote:
> 2013, no (c)

Done.

https://codereview.chromium.org/15734014/diff/1/chrome/browser/webdata/token_...
chrome/browser/webdata/token_web_data.h:33: class TokenWebData : public
WebDataServiceBase {
On 2013/05/23 17:58:08, Jói wrote:
> Maybe one line of documentation? e.g. "Storage for authentication tokens."

Done.

[Roger Tawa OOO till Jul 10th, 2013-05-27 14:22:59]

lgtm for chrome\browser\signin

[commit-bot: I haz the power, 2013-05-27 18:27:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/15734014/11001

[commit-bot: I haz the power, 2013-05-27 21:07:37]

Change committed as 202463