Issue 15732014: InstantExtended: Send SearchProvider suggestions to the page.

Issue 15732014: InstantExtended: Send SearchProvider suggestions to the page. (Closed)

Created:
7 years, 7 months ago by Jered

Modified:
7 years, 6 months ago

Reviewers:
sreeram

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, sreeram, gideonwald, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

InstantExtended: Send SearchProvider suggestions to the page. We're going to send this down after all so the page can properly match Chrome's decision about whether what you've typed is an URL. TEST=Manually with GWS change to deal with SWYT. BUG=243201 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202794

Patch Set 1 #

Total comments: 2

Patch Set 2 : Filter navsuggest and add tests. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -5 lines)			Patch
M	chrome/browser/ui/search/instant_controller.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/instant_controller.cc	View	1	1 chunk	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sreeram

Please add BUG=243201 and a test. https://codereview.chromium.org/15732014/diff/1/chrome/browser/ui/search/instant_controller.cc File chrome/browser/ui/search/instant_controller.cc (left): https://codereview.chromium.org/15732014/diff/1/chrome/browser/ui/search/instant_controller.cc#oldcode628 chrome/browser/ui/search/instant_controller.cc:628: This will end ...

7 years, 7 months ago (2013-05-24 21:00:59 UTC) #2

Jered

PTAL, tests added. On 2013/05/24 21:00:59, sreeram wrote: > Please add BUG=243201 and a test. ...

7 years, 6 months ago (2013-05-28 17:25:24 UTC) #3

Jered

https://codereview.chromium.org/15732014/diff/1/chrome/browser/ui/search/instant_controller.cc File chrome/browser/ui/search/instant_controller.cc (left): https://codereview.chromium.org/15732014/diff/1/chrome/browser/ui/search/instant_controller.cc#oldcode628 chrome/browser/ui/search/instant_controller.cc:628: On 2013/05/24 21:00:59, sreeram wrote: > This will end ...

7 years, 6 months ago (2013-05-28 17:25:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/15732014/4001

7 years, 6 months ago (2013-05-28 23:28:20 UTC) #6

Message was sent while issue was closed.

Change committed as 202794

Expand Messages | Collapse Messages