Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 15732013: Allow animations with inactive observers to reach the Starting state (Closed)

Created:
7 years, 7 months ago by ajuma
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Allow animations with inactive observers to reach the Starting state Currently, when a LayerAnimationController only has an observer in the pending tree, we early-out from Animate and UpdateState in order to prevent animating a layer before it's drawn. However, this means that the position of a layer can change immediately after tree activation (even before a draw), if an animation is started on that layer. This means that tile priorities calculated by UpdateTilePriorites before tree activation can immediately become stale. This CL allows animations with only inactive observers to reach the Starting state and get ticked at their starting point, but progress no further. This means we still won't have running animations on layers before they're drawn. However, this change means that if we ensure that animation always happens before tree activation in each frame (in a follow-up CL), then the tile priorities calculated during tree activation will still be valid when the frame is drawn. BUG=242966 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1 line) Patch
M cc/animation/layer_animation_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 2 chunks +10 lines, -1 line 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ajuma
7 years, 7 months ago (2013-05-24 19:46:00 UTC) #1
Ian Vollick
On 2013/05/24 19:46:00, ajuma wrote: lgtm!
7 years, 6 months ago (2013-05-27 18:23:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/15732013/1
7 years, 6 months ago (2013-05-27 18:58:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118800
7 years, 6 months ago (2013-05-27 21:26:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/15732013/1
7 years, 6 months ago (2013-05-27 21:32:18 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-27 23:47:41 UTC) #6
Message was sent while issue was closed.
Change committed as 202473

Powered by Google App Engine
This is Rietveld 408576698