Issue 15731007: Add dialog-specific styling, restore old-style task manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15731007: Add dialog-specific styling, restore old-style task manager. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add dialog-specific styling, restore old-style task manager. Add per-dialog UseNewStyleForThisDialog() style control. (by default this returns the static UseNewStyle() control) Update DialogDelegate to respect this per-dialog control. Have TaskManagerView always use the old style; cleanup. See before/after pics at http://crbug.com/245000#c1 Do DialogClientView background init in ViewHierarchyChanged. (check the dialog delegate instance for styling control) BUG=245000, 166075 TEST=The task manager always uses the old dialog style. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203044

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -17 lines)			Patch
M	chrome/browser/ui/views/task_manager_view.cc	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	ui/views/window/dialog_client_view.cc	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	ui/views/window/dialog_delegate.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/views/window/dialog_delegate.cc	View	4 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15731007/1

7 years, 6 months ago (2013-05-29 23:38:16 UTC) #3

Message was sent while issue was closed.

Change committed as 203044

Expand Messages | Collapse Messages