Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 15730007: Fixes for Python errors in json_schema_compiler preview server. (Closed)

Created:
7 years, 7 months ago by Tyler Breisacher (Chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes for Python errors in json_schema_compiler preview server. BUG=243997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/json_schema_compiler/preview.py View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tyler Breisacher (Chromium)
7 years, 7 months ago (2013-05-25 09:46:22 UTC) #1
calamity
lgtm, thanks for fixing.
7 years, 7 months ago (2013-05-27 01:27:00 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-28 00:33:52 UTC) #3
Tyler Breisacher (Chromium)
7 years, 7 months ago (2013-05-28 00:35:38 UTC) #4
Kyle Horimoto
lgtm
7 years, 6 months ago (2013-05-30 04:03:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/15730007/1
7 years, 6 months ago (2013-05-30 04:04:36 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 06:52:51 UTC) #7
Message was sent while issue was closed.
Change committed as 203102

Powered by Google App Engine
This is Rietveld 408576698