Use the source display's pixel size as a mirror window's size.

Use the source display's pixel (host) size as a mirror window's size
so that we can copy texture as is.
- store gfx::Display object for mirrored display instead of
  just id because we need one for mirror root window.
- use host window's coordinate for mirror cursor window.

BUG=239776
TEST=covered by unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202985

[oshima, 2013-05-29 01:50:00]

uploaded new CL. This now handles the mirror cursor's location for rotation/ui
scaling correctly.

[Jun Mukai, 2013-05-29 02:08:32]

lgtm

https://codereview.chromium.org/15730006/diff/26001/ash/display/root_window_t...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/15730006/diff/26001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:232: transform_ =
CreateInsetsAndScaleTransform(
Do you need this function?  You can just call Scale method of Transform object.

Also, I'm wondering what will happen if the secondary display has 2x scale
factor.

[oshima, 2013-05-29 03:41:02]

jamescook -> ash owners

https://codereview.chromium.org/15730006/diff/26001/ash/display/root_window_t...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/15730006/diff/26001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:232: transform_ =
CreateInsetsAndScaleTransform(
On 2013/05/29 02:08:32, Jun Mukai wrote:
> Do you need this function?  You can just call Scale method of Transform
object.

This was for letterboxing/pillarboxing code but I removed the logic
from this CL, so changed to simply Scale as suggested.

> Also, I'm wondering what will happen if the secondary display has 2x scale
> factor.

It's texture copy + scale to fit, so there is not DSF concept on secondary
display.

[James Cook, 2013-05-29 12:22:43]

LGTM assuming comments addressed (mostly nits)

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
ash/display/display_manager.cc:443: // works while mirrored.
nit: "scaling to work". Also, this comment seems wrapped too early.

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
ash/display/display_manager.cc:452: //
remove blank comment

https://codereview.chromium.org/15730006/diff/34001/ash/display/mirror_window...
File ash/display/mirror_window_controller.h (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/mirror_window...
ash/display/mirror_window_controller.h:11: #include "ui/aura/window_observer.h"
Do you need this here?

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:131: class ASH_EXPORT
AshRootWindowTransformer : public aura::RootWindowTransformer {
Dumb question: If these are internal classes in a .cc file, do they need
ASH_EXPORT?

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:213: // kthe root window bounds is the
same as the source display's
kthe -> the

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:225: // 1) it does letterbox/pillarbox
to adjust aspect ration
ration -> ratio

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:226: // 2) visible area excluding insets
are corretly mapped
corretly -> correctly

I'm like a human spelling-checker! :-)

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers.h (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.h:30: // and |mirror_dispaly_info|
specifies the display used to
mirror_dispaly_info -> mirror_display_info

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers_unittest.cc (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers_unittest.cc:294: EXPECT_FLOAT_EQ(0.2f,
event_handler.touch_radius_x());
Hooray for "f" suffix - I like it when floats use it.

[oshima, 2013-05-29 15:39:49]

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
ash/display/display_manager.cc:443: // works while mirrored.
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> nit: "scaling to work". Also, this comment seems wrapped too early.

Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/display_manag...
ash/display/display_manager.cc:452: //
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> remove blank comment

Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/mirror_window...
File ash/display/mirror_window_controller.h (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/mirror_window...
ash/display/mirror_window_controller.h:11: #include "ui/aura/window_observer.h"
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> Do you need this here?

Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:131: class ASH_EXPORT
AshRootWindowTransformer : public aura::RootWindowTransformer {
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> Dumb question: If these are internal classes in a .cc file, do they need
> ASH_EXPORT?

good point. I just copied from header and apparently
forgot to remove it. Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:213: // kthe root window bounds is the
same as the source display's
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> kthe -> the

Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:225: // 1) it does letterbox/pillarbox
to adjust aspect ration
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> ration -> ratio

Done.

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.cc:226: // 2) visible area excluding insets
are corretly mapped
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> corretly -> correctly

Done.

> 
> I'm like a human spelling-checker! :-)

Sorry, i wish presubmit has spell checker...

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
File ash/display/root_window_transformers.h (right):

https://codereview.chromium.org/15730006/diff/34001/ash/display/root_window_t...
ash/display/root_window_transformers.h:30: // and |mirror_dispaly_info|
specifies the display used to
On 2013/05/29 12:22:43, James Cook (Chromium) wrote:
> mirror_dispaly_info -> mirror_display_info

Done.

[commit-bot: I haz the power, 2013-05-29 15:40:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15730006/42001

[commit-bot: I haz the power, 2013-05-29 21:51:58]

Change committed as 202985